Comments on: Six Things to Keep in Mind when Considering Code Reviews http://www.icekreamkoan.com/2009/02/17/six-things-to-keep-in-mind-when-considering-code-reviews/ Flying and other stuff - Peter Braswell Fri, 13 Aug 2010 22:27:30 -0700 hourly 1 http://wordpress.org/?v=3.0.1 By: Steve Mixon http://www.icekreamkoan.com/2009/02/17/six-things-to-keep-in-mind-when-considering-code-reviews/comment-page-1/#comment-1493 Steve Mixon Fri, 06 Mar 2009 23:53:31 +0000 http://www.icekreamkoan.com/?p=186#comment-1493 I have three questions I subject activities to: does it share knowledge, create teamwork and increase efficiency. Reviews meet that criteria. I like to spend most effort on designs and design reviews, less on code reviews. I am a big fan of peer reviews for code. During the design phase complicated areas can be identified and targeted for code review and magnitude of review. Also during the design phase, modules targeted for reuse can be identified and given the extra time and quality warranted, implying other code should not be overly designed. Steve Mixon mixonsr@yahoo.com I have three questions I subject activities to: does it share knowledge, create teamwork and increase efficiency. Reviews meet that criteria. I like to spend most effort on designs and design reviews, less on code reviews. I am a big fan of peer reviews for code. During the design phase complicated areas can be identified and targeted for code review and magnitude of review. Also during the design phase, modules targeted for reuse can be identified and given the extra time and quality warranted, implying other code should not be overly designed.

Steve Mixon mixonsr@yahoo.com

]]> By: Gregg Sporar http://www.icekreamkoan.com/2009/02/17/six-things-to-keep-in-mind-when-considering-code-reviews/comment-page-1/#comment-1491 Gregg Sporar Tue, 17 Feb 2009 19:16:11 +0000 http://www.icekreamkoan.com/?p=186#comment-1491 That's a good list, especially the part about not spiraling into an endless discussion. FWIW, a while back our company did a study of code review at Cisco - the results are available in a book that we make available for free on our web site: http://smartbear.com/codecollab-code-review-book.php That’s a good list, especially the part about not spiraling into an endless discussion. FWIW, a while back our company did a study of code review at Cisco – the results are available in a book that we make available for free on our web site: http://smartbear.com/codecollab-code-review-book.php

]]>